From 30ab7d682a473ce9493ae2ad493c48720536190f Mon Sep 17 00:00:00 2001
From: amin <amin.gholizad@gmail.com>
Date: Mon, 25 May 2026 17:42:44 +0200
Subject: [PATCH] edited for new comments

---
 ct/koffan.sh              |  8 ++++----
 install/koffan-install.sh | 22 ++++++++++++++--------
 json/koffan.json          | 12 +++++-------
 3 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/ct/koffan.sh b/ct/koffan.sh
index fc768b37..85c0036d 100644
--- a/ct/koffan.sh
+++ b/ct/koffan.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 source <(curl -s https://raw.githubusercontent.com/AminGholizad/ProxmoxVED/main/misc/build.func)
 # Copyright (c) 2021-2026 community-scripts ORG
-# Author: Amin Gholizad
+# Author: [AminGholizad]
 # License: MIT | https://github.com/AminGholizad/ProxmoxVED/raw/main/LICENSE
 # Source: https://github.com/PanSalut/Koffan
 
@@ -35,10 +35,10 @@ function update_script() {
     msg_ok "Stopped Service"
 
     msg_info "Backing up Data"
-    cp -r /opt/koffan/data /opt/koffan_data_backup 2>/dev/null || true
+    cp -r /opt/koffan/data /opt/koffan_data_backup
     msg_ok "Backed up Data"
 
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "koffan" "PanSalut/Koffan"
+    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "koffan" "PanSalut/Koffan" "tarball"
 
     msg_info "Rebuilding Koffan"
     cd /opt/koffan
@@ -46,7 +46,7 @@ function update_script() {
     msg_ok "Rebuild Completed"
 
     msg_info "Restoring Data"
-    cp -r /opt/koffan_data_backup/. /opt/koffan/data/ 2>/dev/null || true
+    cp -r /opt/koffan_data_backup/. /opt/koffan/data/
     rm -rf /opt/koffan_data_backup
     msg_ok "Restored Data"
 
diff --git a/install/koffan-install.sh b/install/koffan-install.sh
index 80ae33bd..fe5bfb06 100644
--- a/install/koffan-install.sh
+++ b/install/koffan-install.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
 # Copyright (c) 2021-2026 community-scripts ORG
-# Author: Amin Gholizad
+# Author: [AminGholizad]
 # License: MIT | https://github.com/AminGholizad/ProxmoxVED/raw/main/LICENSE
 # Source: https://github.com/PanSalut/Koffan
 
@@ -13,25 +13,32 @@ setting_up_container
 network_check
 update_os
 
+msg_info "Installing Dependencies"
 ensure_dependencies build-essential
 setup_go
+msg_ok "Installed Dependencies"
 
-fetch_and_deploy_gh_release "koffan" "PanSalut/Koffan"
+fetch_and_deploy_gh_release "koffan" "PanSalut/Koffan" "tarball"
 
 msg_info "Building Koffan"
 cd /opt/koffan
 go build -o koffan main.go
-msg_ok "Building Completed"
+msg_ok "Built Koffan"
 
 msg_info "Configuring Koffan"
+PASSWORD=$(openssl rand -base64 12)
 mkdir /opt/koffan/data
 cat <<EOF >/opt/koffan/data/.env
 APP_ENV=production
-APP_PASSWORD=shopping123
+APP_PASSWORD=${PASSWORD}
 PORT=3000
 DB_PATH=/opt/koffan/data/shopping.db
 EOF
-msg_ok "Configuration Completed"
+
+{
+  echo "Password: ${PASSWORD}"
+} >~/koffan.creds
+msg_ok "Configured Koffan"
 
 msg_info "Creating systemd service"
 cat <<EOF >/etc/systemd/system/koffan.service
@@ -48,11 +55,10 @@ Restart=always
 [Install]
 WantedBy=multi-user.target
 EOF
-msg_ok "Service created"
 
-msg_info "Finalizing Koffan installation"
 systemctl enable -q --now koffan
+msg_ok "Created systemd service"
+
 motd_ssh
 customize
-msg_ok "Koffan installation complete"
 cleanup_lxc
diff --git a/json/koffan.json b/json/koffan.json
index 456cc78d..e1263cf3 100644
--- a/json/koffan.json
+++ b/json/koffan.json
@@ -1,14 +1,12 @@
 {
   "name": "Koffan",
   "slug": "koffan",
-  "categories": [
-    12
-  ],
+  "categories": [12],
   "date_created": "2026-05-21",
   "type": "ct",
   "updateable": true,
   "privileged": false,
-  "interface_port": null,
+  "interface_port": 3000,
   "documentation": null,
   "website": null,
   "logo": "https://cdn.jsdelivr.net/gh/selfhst/icons@main/webp/koffan.webp",
@@ -33,8 +31,8 @@
   },
   "notes": [
     {
-      "text": "Change the default password after first login!",
-      "type": "warning"
+      "text": "Credentials are saved to `~/koffan.creds`.",
+      "type": "info"
     }
   ]
-}
\ No newline at end of file
+}