From e63137e9d20ecfb969e2212edb33900ccd3d86f4 Mon Sep 17 00:00:00 2001 From: "CanbiZ (MickLesk)" <47820557+MickLesk@users.noreply.github.com> Date: Mon, 23 Mar 2026 15:28:12 +0100 Subject: [PATCH] fix(arm): fix MakeMKV version detection on download page The grep pattern 'makemkv-bin-' no longer matches the download page HTML. Switched to 'MakeMKV v?X.Y.Z' which matches the visible page content. Also added -f flag to curl and a guard for empty version. --- install/arm-install.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/install/arm-install.sh b/install/arm-install.sh index a6b2e633..971a4f87 100644 --- a/install/arm-install.sh +++ b/install/arm-install.sh @@ -43,7 +43,11 @@ msg_ok "Installed Dependencies" PYTHON_VERSION="3.12" setup_uv msg_info "Building MakeMKV (Patience)" -MAKEMKV_VER=$(curl -sL https://www.makemkv.com/download/ | grep -oP 'makemkv-bin-\K[0-9]+\.[0-9]+\.[0-9]+' | head -1) +MAKEMKV_VER=$(curl -fsSL https://www.makemkv.com/download/ | grep -oP 'MakeMKV[_ ]v?\K[0-9]+\.[0-9]+\.[0-9]+' | head -1) +if [[ -z "${MAKEMKV_VER}" ]]; then + msg_error "Failed to determine MakeMKV version from download page" + exit 1 +fi cd /tmp $STD curl -fsSL -o makemkv-oss.tar.gz "https://www.makemkv.com/download/makemkv-oss-${MAKEMKV_VER}.tar.gz" $STD curl -fsSL -o makemkv-bin.tar.gz "https://www.makemkv.com/download/makemkv-bin-${MAKEMKV_VER}.tar.gz"