chore: fixes for release automation (#5142)

.github/workflows/ci-homebrew.yml

@@ -161,14 +161,6 @@ jobs:
           # testing
           cat ./homebrew/sunshine.rb
 
-      - name: Upload Artifacts
-        if: matrix.release
-        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a  # v7.0.1
-        with:
-          name: build-Homebrew
-          path: homebrew/
-          if-no-files-found: error
-
       - name: Setup Xvfb
         if: matrix.release != true && runner.os == 'Linux'
         run: |
@@ -210,6 +202,25 @@ jobs:
           if-no-files-found: error
 
       - name: Patch homebrew formula
+        # remove version from formula as it's not necessary for release versions
+        # don't run this on macOS, as the sed command fails
+        if: matrix.release
+        run: |
+          # variables
+          formula_file="homebrew/sunshine.rb"
+
+          # remove the formula version
+          sed -i '/^  version .*$/d' $formula_file
+
+      - name: Upload Artifacts
+        if: matrix.release
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a  # v7.0.1
+        with:
+          name: build-Homebrew
+          path: homebrew/
+          if-no-files-found: error
+
+      - name: Patch homebrew formula (Beta)
         # create beta version of the formula
         # don't run this on macOS, as the sed command fails
         if: matrix.release
@@ -223,7 +234,6 @@ jobs:
           # update the formula
           sed -i 's/class Sunshine < Formula/class SunshineBeta < Formula/' $formula_file
           sed -i 's/conflicts_with "sunshine-beta"/conflicts_with "sunshine"/' $formula_file
-          sed -i '/^  version .*$/d' $formula_file
 
           # update livecheck to check for latest stable or pre-release
           # shellcheck disable=SC1004
@@ -239,10 +249,6 @@ jobs:
                 end\
               end' $formula_file
 
-          # print new file
-          echo "New formula:"
-          cat $formula_file
-
       - name: Upload Artifacts (Beta)
         if: matrix.release
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a  # v7.0.1

docs/maintainers/release.md

@@ -28,7 +28,6 @@ to be created before making a stable release. Below are the instructions for con
 
        - LizardByte Discord
        - r/LizardByte subreddit
-       - Twitter
        - Facebook
 
    - Update changelog in [changelog](https://github.com/LizardByte/Sunshine/tree/changelog) branch
@@ -42,3 +41,5 @@ to be created before making a stable release. Below are the instructions for con
      via a PR (we DO NOT have merge control)
    - Build the new version in [stable copr repo](https://copr.fedorainfracloud.org/coprs/lizardbyte/stable/)
    - Send release notification to Moonlight Discord server
+
+6. X (Twitter) API is no longer free, so we must manually post the release there.

packaging/linux/dev.lizardbyte.app.Sunshine.metainfo.xml

@@ -24,11 +24,9 @@
   <url type="contact">https://app.lizardbyte.dev/support</url>
 
   <description>
-    <p>
-      @PROJECT_LONG_DESCRIPTION@
-    </p>
+    <p>@PROJECT_LONG_DESCRIPTION@</p>
 
-    <p>NOTE: Sunshine requires additional installation steps (Flatpak).</p>
+    <p>NOTE: Sunshine requires additional installation steps on Flatpak.</p>
     <p>
       <code>flatpak run --command=additional-install.sh @PROJECT_FQDN@</code>
     </p>
@@ -37,12 +35,9 @@
 
   <releases>
     <release version="@PROJECT_VERSION@" date="@PROJECT_YEAR@-@PROJECT_MONTH@-@PROJECT_DAY@">
+      <url>https://github.com/LizardByte/Sunshine/releases/tag/v@PROJECT_VERSION@</url>
       <description>
-        <p>
-          See the full changelog on GitHub
-
-          <!-- changelog -->
-        </p>
+        <p>See the changelog on GitHub</p>
       </description>
     </release>
   </releases>